Add grpc helpers to python #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosms
approved these changes
Nov 27, 2018
language-analyzer.py
Outdated
| # Example Analyser gRPC service implementation. | ||
| # Posts file-level comments for every file with language detected. | ||
| """ | ||
| Example Analyser gRPC service implementation. |
Contributor
There was a problem hiding this comment.
For consistency,
Suggested change
| Example Analyser gRPC service implementation. | |
| Example Analyzer gRPC service implementation. |
dpordomingo
approved these changes
Nov 27, 2018
Contributor
dpordomingo
left a comment
dpordomingo
left a comment
There was a problem hiding this comment.
Wiiiiii!
many thanks @smacker !
Merged
similar to go: - create_channel: replacement with increased message size - to_grpc_address: converter RFC 3986 input to grpcio one Signed-off-by: Maxim Sukharev <[email protected]>
Signed-off-by: Maxim Sukharev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #35 (because of README.md conflicts)
Only 2 new commits: