Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

Conversation

@kuba--
Copy link
Contributor

@kuba-- kuba-- commented Jan 29, 2019

Signed-off-by: kuba-- [email protected]
Closes #597

Signed-off-by: kuba-- <[email protected]>
@kuba-- kuba-- requested review from a team and smola January 29, 2019 21:39
Copy link
Contributor

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't mix gitbase with go-mysql-server

I (@kuba) agree - @smola - WDYT ^^^

try:
with connection.cursor() as cursor:
sql = "SELECT foo FROM bar"
sql = "SELECT * FROM commit_files LIMIT 1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are go-mysql-server examples, not gitbase examples. I don't think we should mix the two of them

@kuba--
Copy link
Contributor Author

kuba-- commented Jan 30, 2019

@smola - WDYT? Maybe docs should follow the schema from _example

@kuba--
Copy link
Contributor Author

kuba-- commented Jan 31, 2019

@src-d/data-processing, @smola
I replaced all gitbase related terms by mydb and mytable.
Also I've added C-test and C example. I know it's a language for dinosaurs, but I'm one of them ;)

Copy link
Contributor

@erizocosmico erizocosmico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass

Signed-off-by: kuba-- <[email protected]>
@ajnavarro ajnavarro merged commit d3cf828 into src-d:master Feb 5, 2019
@kuba-- kuba-- deleted the doc-597 branch February 6, 2019 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants