This repository was archived by the owner on Jan 28, 2021. It is now read-only.
sql/analyzer: remove QueryProcess nodes from subqueries #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes src-d/gitbase#679 Because subqueries are analyzed as if they were a whole independent query QueryProcess nodes were added to them. That caused that as soon as a subquery finished, the process were marked as done. As a result, some queries could error with "context canceled", as the context of the query had already been canceled. This fix removes the QueryProcess nodes from any subquery and makes sure only the root node is wrapped in a QueryProcess. Signed-off-by: Miguel Molina <[email protected]>
kuba--
approved these changes
Jan 23, 2019
mcarmonaa
approved these changes
Jan 23, 2019
Contributor
Author
|
Merging this because it's blocking a task for the PoC. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes src-d/gitbase#679
Because subqueries are analyzed as if they were a whole independent
query QueryProcess nodes were added to them. That caused that as
soon as a subquery finished, the process were marked as done. As a
result, some queries could error with "context canceled", as the
context of the query had already been canceled.
This fix removes the QueryProcess nodes from any subquery and makes
sure only the root node is wrapped in a QueryProcess.
Signed-off-by: Miguel Molina [email protected]