This repository was archived by the owner on Jan 28, 2021. It is now read-only.
sql/plan: speed up InnerJoin iterator #578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
erizocosmico
commented
Dec 21, 2018
erizocosmico
commented
kuba--
reviewed
Dec 21, 2018
kuba--
approved these changes
Dec 21, 2018
jfontan
approved these changes
Dec 21, 2018
Contributor
|
@erizocosmico LGTM, but could you have a look at @kuba-- and @jfontan comments? thanks! |
Contributor
Author
|
Sure @ajnavarro |
pkg: gopkg.in/src-d/go-mysql-server.v0/sql/plan BenchmarkInnerJoin/inner_join-4 50000 34188 ns/op 11415 B/op 169 allocs/op BenchmarkInnerJoin/cross_join_with_filter-4 30000 41608 ns/op 12119 B/op 181 allocs/op PASS ok gopkg.in/src-d/go-mysql-server.v0/sql/plan 3.795s Signed-off-by: Miguel Molina <[email protected]>
erizocosmico
force-pushed
the
perf/inner-join
branch
from
b19c55a to
ca55244
Compare
Contributor
Author
|
Done |
jfontan
approved these changes
Jan 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.