This repository was archived by the owner on Jan 28, 2021. It is now read-only.
sql: process list now shows client address #517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfontan
force-pushed
the
fix/client-address-in-session
branch
from
4eb7f16 to
65150c0
Compare
kuba--
approved these changes
Oct 31, 2018
| // Session holds the session data. | ||
| type Session interface { | ||
| // Address of the server. | ||
| Address() string |
Contributor
There was a problem hiding this comment.
I thought we don't need it.
Contributor
Author
There was a problem hiding this comment.
We need client's address for process list and audit logs that I'm currently adding. What we don't need is server address Session.Address. I've left as it is already implemented and would break backwards compatibility.
erizocosmico
approved these changes
Oct 31, 2018
mcarmonaa
approved these changes
Oct 31, 2018
Contributor
|
@jfontan could you rebase to fix CI please? |
Previously it was showing server address but should be the client: https://dev.mysql.com/doc/refman/8.0/en/processlist-table.html Also merged client user and address as Client struct in session. Signed-off-by: Javi Fontan <[email protected]>
jfontan
force-pushed
the
fix/client-address-in-session
branch
from
65150c0 to
2eaa2da
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was showing server address but should be the client:
https://dev.mysql.com/doc/refman/8.0/en/processlist-table.html
Also merged client user and address as Client struct in session.