This repository was archived by the owner on Jan 28, 2021. It is now read-only.
sql: add timing info to span traces #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuba--
reviewed
Oct 18, 2018
sql/session.go
Outdated
| log.String("total_time", i.total.String()), | ||
| log.String("max_time", i.max.String()), | ||
| log.String("min_time", i.min.String()), | ||
| log.String("avg_time", (i.total / time.Duration(i.count)).String()), |
Contributor
There was a problem hiding this comment.
is it possible here to have div by 0?
Contributor
Author
There was a problem hiding this comment.
yep, you're right
Signed-off-by: Miguel Molina <[email protected]>
erizocosmico
force-pushed
the
trace-timing
branch
from
3078a44 to
3e24d6a
Compare
Contributor
Author
|
Just fixed the div by 0 thing |
kuba--
approved these changes
Oct 18, 2018
mcarmonaa
approved these changes
Oct 18, 2018
ajnavarro
approved these changes
Oct 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #466