This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Implement SHOW VARIABLES #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 12, 2018 20:28
Signed-off-by: kuba-- <[email protected]>
Signed-off-by: kuba-- <[email protected]>
Signed-off-by: kuba-- <[email protected]>
mcarmonaa
reviewed
Oct 16, 2018
sql/plan/showvariables.go
Outdated
| } | ||
|
|
||
| func (it *showVariablesIter) Next() (sql.Row, error) { | ||
| i := atomic.LoadUint32(&it.offset) |
Contributor
There was a problem hiding this comment.
Why is necessary manage offset and total as atomic variables?
On the other hand, if names and values are already in memory maybe we can build directly a slice of rows and return as iterator in the RowIter method sql.RowsToRowIter(rows)
erizocosmico
suggested changes
Oct 16, 2018
Contributor
erizocosmico
left a comment
erizocosmico
left a comment
There was a problem hiding this comment.
Also, what Manu said
sql/parse/variables.go
Outdated
| func parseShowVariables(ctx *sql.Context, s string) (sql.Node, error) { | ||
| var ( | ||
| pattern string | ||
| ) |
Contributor
There was a problem hiding this comment.
can just be var pattern string
Signed-off-by: kuba-- <[email protected]>
Contributor
Author
|
@erizocosmico, @mcarmonaa - ok, done. |
erizocosmico
approved these changes
Oct 16, 2018
mcarmonaa
approved these changes
Oct 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #409
The PR implements:
SHOW [global | session] VARIABLES [LIKE pattern]where global, session are ignored (we copy config from
BaseSession).So far it supports
LIKEcondition. In the future we can also addWHERE