This repository was archived by the owner on Jan 28, 2021. It is now read-only.
sql: plan: Add SHOW CREATE TABLE [Fix #406] #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Theodoros Zarkopafilis Ntakouris <[email protected]>
ajnavarro
requested review from
erizocosmico,
kuba-- and
mcarmonaa
and removed request for
erizocosmico
kuba--
reviewed
Oct 10, 2018
erizocosmico
approved these changes
Oct 10, 2018
Signed-off-by: Theodoros Zarkopafilis Ntakouris <[email protected]>
kuba--
approved these changes
Oct 10, 2018
…e name instead Signed-off-by: Theodoros Zarkopafilis Ntakouris <[email protected]>
Signed-off-by: Theodoros Zarkopafilis Ntakouris <[email protected]>
Signed-off-by: Theodoros Zarkopafilis Ntakouris <[email protected]>
…talog Signed-off-by: Theodoros Zarkopafilis Ntakouris <[email protected]>
Signed-off-by: Theodoros Zarkopafilis Ntakouris <[email protected]>
mcarmonaa
reviewed
Oct 12, 2018
…REATE TABLE Signed-off-by: Theodoros Zarkopafilis Ntakouris <[email protected]>
Signed-off-by: Theodoros Zarkopafilis Ntakouris <[email protected]>
mcarmonaa
reviewed
Oct 15, 2018
Signed-off-by: Theodoros Zarkopafilis Ntakouris <[email protected]>
Contributor
|
@Zarkopafilis can you rebase please? |
Contributor
|
@Zarkopafilis CI is failing now, can you please take a look at it? |
Signed-off-by: Theodoros Zarkopafilis Ntakouris <[email protected]>
Contributor
Author
|
I have no idea why this happened. Fixed. |
Contributor
|
Shall we merge this, @ajnavarro? |
Contributor
|
It is still failing @erizocosmico @Zarkopafilis |
Signed-off-by: Theodoros Zarkopafilis Ntakouris <[email protected]>
Contributor
Author
|
Excuse me, apparently something is off with my golang installation and eveything seemed fine. Rebase worked but the Catalog interface got changed a bit. |
Contributor
|
@ajnavarro now it's ok. It's failing because of the java thing, but the fix is on master anyway. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#406
Signed-off-by: Theodoros Zarkopafilis Ntakouris [email protected]