Skip to content

Add jenkins slack notifications #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2019
Merged

Add jenkins slack notifications #90

merged 1 commit into from
Oct 28, 2019

Conversation

@lwsanty
Copy link
Contributor

@lwsanty lwsanty commented Oct 23, 2019

No description provided.

@lwsanty lwsanty requested review from jfontan and mcarmonaa October 23, 2019 10:31
@lwsanty lwsanty self-assigned this Oct 23, 2019
@lwsanty lwsanty force-pushed the add-jenkins-slack-notifications branch from 84aac71 to 2c05145 Compare October 23, 2019 10:32
@jfontan
Copy link
Contributor

jfontan commented Oct 23, 2019

I've restarted the tests. There's also this case in the boken api test:

    --- FAIL: TestAll/testPeriodicallyBrokenGithubAPI (0.09s)
        download_test.go:371: 
            	Error Trace:	download_test.go:371
            	            				download_test.go:138
            	Error:      	"Get https://github.com/apoliukh/awesome-sysadmin.git/info/refs?service=git-upload-pack: Forbidden" does not contain "Internal Server Error"
            	Test:       	TestAll/testPeriodicallyBrokenGithubAPI

@lwsanty
Copy link
Contributor Author

lwsanty commented Oct 23, 2019

yep, that's weird, I cannot reproduce it locally

@jfontan
Copy link
Contributor

jfontan commented Oct 23, 2019

Another case:

    --- FAIL: TestAll/testPeriodicallyBrokenGithubAPI (0.10s)
        download_test.go:371: 
            	Error Trace:	download_test.go:371
            	            				download_test.go:138
            	Error:      	"Get https://github.com/MunGell/awesome-for-beginners.git/info/refs?service=git-upload-pack: Moved Permanently" does not contain "Internal Server Error"
            	Test:       	TestAll/testPeriodicallyBrokenGithubAPI

@lwsanty lwsanty force-pushed the add-jenkins-slack-notifications branch 6 times, most recently from 5bb5236 to 1ebaf43 Compare October 24, 2019 12:57
@lwsanty lwsanty force-pushed the add-jenkins-slack-notifications branch from ecfb2c3 to 0fde644 Compare October 24, 2019 15:21
@lwsanty
Copy link
Contributor Author

lwsanty commented Oct 24, 2019

@jfontan fixed

@jfontan jfontan merged commit f683a2a into master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jfontan jfontan jfontan approved these changes

@mcarmonaa mcarmonaa mcarmonaa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lwsanty lwsanty

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lwsanty @jfontan @mcarmonaa