Skip to content

*: do not lock on worker pool wait and wait backoff on error for scheduling #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2019
Merged

*: do not lock on worker pool wait and wait backoff on error for scheduling #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb18e17
*: do not lock on WorkerPool.Wait
mcarmonaa Jul 22, 2019
9f14823
*: wait with backoff for any error on scheduling
mcarmonaa Jul 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions scheduler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,18 +91,19 @@ func (s *jobScheduler) Schedule() {
continue
}

select {
case <-s.cancel:
return
case <-time.After(s.backoff.Duration()):
}
}

if ErrJobSource.Is(err) {
close(s.jobs)
return
}

select {
case <-s.cancel:
return
case <-time.After(s.backoff.Duration()):
}

continue
}

Expand Down
6 changes: 1 addition & 5 deletions worker_pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,8 @@ func (wp *WorkerPool) remove(n int) {
wg.Wait()
}

// Wait waits for the workers to finish. A worker will finish when the queue to
// retrieve jobs from is closed.
// Wait waits for the workers to finish.
func (wp *WorkerPool) Wait() {
<-wp.resize
defer func() { wp.resize <- struct{}{} }()

wp.wg.Wait()
wp.workers = nil
wp.opts.Metrics.Stop(false)
Expand Down