Use floats instead of doubles in wmh #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 32 bit precision is enough for us - we drop the rest when we calculate hashtables anyway - change should reduce required memory for wmh instance twice Signed-off-by: Maxim Sukharev <[email protected]>
Contributor
Author
|
FileQuery test has failed but with manual testing everything works file. I'm looking into it. (most probably the problem is in the test itself) |
Signed-off-by: Maxim Sukharev <[email protected]>
Contributor
Author
|
Fixed. I had to update all related fixtures not only hashtables because go-driver started returning a little bit different results -> different features -> different docfreq. |
Signed-off-by: Maxim Sukharev <[email protected]>
carlosms
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maxim Sukharev [email protected]