fix: filter out too long feature names #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
se7entyse7en
suggested changes
Feb 6, 2019
| // 65535 is the limit for a key in Scylla | ||
| // key = (hash mode, feature.name) | ||
| // and it's just sane to remove such huge name | ||
| .filter(feat => feat.name.length < 65530) |
There was a problem hiding this comment.
You can also write this as follows:
Suggested change
| .filter(feat => feat.name.length < 65530) | |
| .filter(_.name.length < 65530) |
In some cases writing docFreq to db can fail with error: Key size too large: N > 65535 Inspecting DB after such failure I see feature names like: ArrayExpression_ArrayExpression_[repeat many times]_ArrayExpression Most probably it's a bug in UAST or Feature Extractor but gemini shouldn't fail because of it anyway. Signed-off-by: Maxim Sukharev <[email protected]>
se7entyse7en
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases writing docFreq to db can fail with error:
Key size too large: N > 65535
Inspecting DB after such failure I see feature names like:
ArrayExpression_ArrayExpression_[repeat many times]_ArrayExpression
Most probably it's a bug in UAST or Feature Extractor but gemini
shouldn't fail because of it anyway.
Signed-off-by: Maxim Sukharev [email protected]