add support for Amazon Web Services S3 #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Don't merge until we test it with real S3 account. |
|
What do you need to test this? |
smacker
requested review from
carlosms,
se7entyse7en and
smola
and removed request for
se7entyse7en
carlosms
reviewed
Jan 29, 2019
Contributor
carlosms
left a comment
carlosms
left a comment
There was a problem hiding this comment.
LGTM, but it would be good to document it in the readme
Contributor
Author
|
we don't have any mention about hdfs, gcs or aws in readme right now. Let's create an issue for that? |
Contributor
|
ok if you need it right now for the PoC let's open an issue for the docs |
carlosms
approved these changes
Jan 29, 2019
Contributor
Author
|
It's not really about "right now" but I would prefer to describe all storages in one task than doing just s3 here. I created an issue: #186 |
Allow all URI supported by hadoop-aws: - s3:// - deprecated - s3n:// -deprecated - s3a:// - recommended The URI may contain AWS key & secret (as login & password) for the simpliest case. Similar to GCS hadoop-aws included into fat deps jar to avoid conflicts. Signed-off-by: Maxim Sukharev <[email protected]>
Signed-off-by: Maxim Sukharev <[email protected]>
Contributor
Author
|
rebased on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As usual, it took a while to figure which versions should be used to avoid conflicts.
s3a available since Hadoop 2.6 and considered stable since Hadoop 2.7
Allow all URI supported by hadoop-aws:
The URI may contain AWS key & secret (as login & password) for the
simplest case.
Similar to GCS hadoop-aws included into fat deps jar to avoid conflicts.
Signed-off-by: Maxim Sukharev [email protected]