Add json output for report command #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxim Sukharev <[email protected]>
Replace --format param with --cassandra format which would enable advanced cql queries. Now functionality with Cassandra & ScyllaDB are the same. Signed-off-by: Maxim Sukharev <[email protected]>
Signed-off-by: Maxim Sukharev <[email protected]>
Signed-off-by: Maxim Sukharev <[email protected]>
Signed-off-by: Maxim Sukharev <[email protected]>
Signed-off-by: Maxim Sukharev <[email protected]>
Contributor
Author
|
Output example: $ ./report --output-format=json | tail -n +2 | jq
{
"duplicates": [
[
{
"repo": "github.com/erizocosmico/borges.git",
"commit": "b1fcd3bf0ba810c05cb418babc09cc7f7783cc03",
"path": "MAINTAINERS",
"sha": "dc6817245a5213ab250471276acb61c186acab11"
},
{
"repo": "github.com/src-d/borges.git",
"commit": "e784f9d5f59d5c081c5f8f71b6c517918b899df0",
"path": "MAINTAINERS",
"sha": "dc6817245a5213ab250471276acb61c186acab11"
}
],
...
],
"similarities": [
[
{
"file": {
"repo": "github.com/src-d/borges.git",
"commit": "e784f9d5f59d5c081c5f8f71b6c517918b899df0",
"path": "consumer_test.go",
"sha": "c1dc2a658b05a68f6e68cffe953d119898f2f657"
}
},
{
"file": {
"repo": "github.com/erizocosmico/borges.git",
"commit": "b1fcd3bf0ba810c05cb418babc09cc7f7783cc03",
"path": "consumer_test.go",
"sha": "f55507972a35a9fb080a41d769d7ff2526a605be"
}
}
],
...
]
} |
carlosms
approved these changes
Jan 22, 2019
Contributor
carlosms
left a comment
carlosms
left a comment
There was a problem hiding this comment.
LGTM, although it would be nice to have docs for the new option. Maybe we can open an issue to document it later to not block the PoC.
Signed-off-by: Maxim Sukharev <[email protected]>
Contributor
Author
|
Thanks! Added new cli params to README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need it for PoC.