Skip to content

Conversation

@rafaelespinoza
Copy link

This is a nice tool. But there are some minor usability annoyances with the input flags.

Addresses the host= flag short-form that conflicts with --help's short form. Both are -h and help takes precedence. Get around this by specifying an alternative short-form for host. This is similar to #22.
Fix a typo in usage text.
Adds some other missing short-form flags.

I was careful to look for creating conflicts and couldn't find any new ones. Going through each subcommand's usage func shows that it still works. From what I understand, if there was a conflicting flag, then beanstool <subcommand> -h would output something like:

"Unknown command `delete'. Please specify one command of: bury, kick, peek, put, stats or tail

Which doesn't seem to happen.
Let me know what you think, thanks.

The -h flag conflicts with help. Now you don't need to type out the
entire long-form of the flag to specify a host.

Signed-off-by: Rafael Espinoza <[email protected]>
Signed-off-by: Rafael Espinoza <[email protected]>
Signed-off-by: Rafael Espinoza <[email protected]>
Didn't do Put.TTR flag since it'd conflict with Tube.

Signed-off-by: Rafael Espinoza <[email protected]>
Signed-off-by: Rafael Espinoza <[email protected]>
@rafaelespinoza rafaelespinoza marked this pull request as ready for review August 31, 2020 00:33
@rafaelespinoza rafaelespinoza changed the title Update cli flags Add short flags and fix conflicting host flag Aug 31, 2020
Signed-off-by: Rafael Espinoza <[email protected]>
@rafaelespinoza rafaelespinoza force-pushed the re/update_cli_flags branch 2 times, most recently from aa68adb to b26d609 Compare October 1, 2025 15:26
rafaelespinoza added a commit to rafaelespinoza/beanstool that referenced this pull request Oct 1, 2025
This squashed commit is the same set of changes in src-d#24,
as of 2025-10-01.

Squashed commit of the following:

commit abe3fa0
Author: Rafael Espinoza <[email protected]>
Date:   Sat Sep 12 12:04:59 2020 -0700

    fix two build issues

    Signed-off-by: Rafael Espinoza <[email protected]>

commit b26d609
Author: Rafael Espinoza <[email protected]>
Date:   Sun Aug 30 16:56:03 2020 -0700

    fix typo in Tail.Action flag usage

    Signed-off-by: Rafael Espinoza <[email protected]>

commit d39941b
Author: Rafael Espinoza <[email protected]>
Date:   Sun Aug 30 16:54:34 2020 -0700

    Add most remaining shortflags

    Didn't do Put.TTR flag since it'd conflict with Tube.

    Signed-off-by: Rafael Espinoza <[email protected]>

commit be8b7c2
Author: Rafael Espinoza <[email protected]>
Date:   Sun Aug 30 16:45:48 2020 -0700

    Add short flags for num

    Signed-off-by: Rafael Espinoza <[email protected]>

commit 28c6454
Author: Rafael Espinoza <[email protected]>
Date:   Sun Aug 30 16:42:36 2020 -0700

    Add short flag for state

    Signed-off-by: Rafael Espinoza <[email protected]>

commit 66403be
Author: Rafael Espinoza <[email protected]>
Date:   Sun Aug 30 16:39:51 2020 -0700

    fix(cli): Change short host flag to -H

    The -h flag conflicts with help. Now you don't need to type out the
    entire long-form of the flag to specify a host.

    Signed-off-by: Rafael Espinoza <[email protected]>

Signed-off-by: Rafael Espinoza <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant