Skip to content

[FEATURE] Add preprocess (repos_2bow_index in ml) #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2018
Merged

[FEATURE] Add preprocess (repos_2bow_index in ml) #61

merged 1 commit into from
Jul 24, 2018

Conversation

@r0mainK
Copy link
Contributor

@r0mainK r0mainK commented Jun 18, 2018 •
edited
Loading

See PR in ml FIRST

CONTEXT

To be merged after ml PR is approved, and not else wise.

CHANGES

  • main: added pickle_index as an optional input or output path. if supplied, the pickle will be loaded from the location, or be saved - in which case the metadata and bags will not be written
  • bags: logic of above functionality

@r0mainK r0mainK mentioned this pull request Jun 18, 2018
Merged
@r0mainK r0mainK changed the title Add early stop feature and pickle index feature [WIP] Add early stop feature and pickle index feature Jun 18, 2018
@r0mainK r0mainK changed the title [WIP] Add early stop feature and pickle index feature Add early stop feature and pickle index feature Jun 21, 2018
@r0mainK
Copy link
Contributor Author

r0mainK commented Jun 26, 2018

OKay going to update this PR so it can get merged.

@r0mainK r0mainK mentioned this pull request Jun 26, 2018
Open
vmarkovtsev
vmarkovtsev requested changes Jul 4, 2018
View reviewed changes
apollo/__main__.py
add_cassandra_args(source2bags_parser)
add_df_args(source2bags_parser)
add_repartitioner_arg(source2bags_parser)
source2bags_parser.add_argument(
Copy link
Collaborator

@vmarkovtsev vmarkovtsev Jul 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we should move it to sourced-ml and re-use here

Copy link
Contributor Author

@r0mainK r0mainK Jul 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on it, will add to src-d/ml#285

@vmarkovtsev
Copy link
Collaborator

vmarkovtsev commented Jul 5, 2018

Waits for src-d/ml#285

@r0mainK r0mainK changed the title Add early stop feature and pickle index feature [FEATURE] Add preprocess (repos_2bow_index in ml) Jul 12, 2018
@vmarkovtsev vmarkovtsev merged commit 2a9b0ae into src-d:master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmarkovtsev vmarkovtsev vmarkovtsev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@r0mainK @vmarkovtsev