New modal component #934
New modal component #934
Conversation
…opening of a modal box
| ('contents','A paragraph of text to display, without any formatting, without having to make additional queries.','TEXT',FALSE,TRUE), | ||
| ('contents_md','Rich text in the markdown format. Among others, this allows you to write bold text using **bold**, italics using *italics*, and links using [text](https://example.com).','TEXT',FALSE,TRUE), | ||
| ('unsafe_contents_md','Markdown format with html blocks. Use this only with trusted content. See the html-blocks section of the Commonmark spec for additional info.','TEXT',FALSE,TRUE), | ||
| ('scrollable','Dreate a scrollable modal that allows scroll the modal body.','BOOLEAN',TRUE,TRUE), |
There was a problem hiding this comment.
| ('scrollable','Dreate a scrollable modal that allows scroll the modal body.','BOOLEAN',TRUE,TRUE), | |
| ('scrollable','Create a scrollable modal that allows scroll the modal body.','BOOLEAN',TRUE,TRUE), |
There was a problem hiding this comment.
ok, corrected
sqlpage/templates/modal.handlebars
Outdated
| {{~#if unsafe_contents_md~}} | ||
| {{{markdown unsafe_contents_md 'allow_unsafe'}}} | ||
| {{else}} |
There was a problem hiding this comment.
Can we remove this ? This is a more general problem with sqlpage and I think it should be either everywhere or nowhere.
What we could have instead is an embed property (same as in the card component) to embed another page. This is safe and more user-friendly.
There was a problem hiding this comment.
I'll try to implement embed, but I'll need to make the modal box fit the dimensions of the embedded content.
|
Thank you very much for this contribution ! Are you using this component already in your projects ? In which context ? The inability to dynamically open the modal seems a little bit impractical. |
Yes, I use it in my projects. The opening of modal boxes is triggered by the Button component. I use them to display additional information or contextual help. Modal boxes can also be opened with javascript. |
New modal component and upgrade of the button component to allow the opening of a modal box.