separate logs and only reveal progress in console #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
CelestaLiu
commented
Jul 29, 2025
CelestaLiu
commented
- Separate logs into docker.log, script.log and sqlancer.log
- docker.log records docker command running trace, script.log records the testing progress, sqlancer.log records testing information within sqlancer docker
- The console only shows testing progress
suyZhong
requested changes
Jul 29, 2025
Collaborator
suyZhong
left a comment
suyZhong
left a comment
There was a problem hiding this comment.
We can log more detailed information when setting up containers.
build.py
Outdated
| images = result.stdout.strip().splitlines() | ||
| if "sqlancer:latest" in images: | ||
| print("[INFO] SQLancer image already exists: sqlancer:latest") | ||
| script_log.info("SQLancer image exists") |
Collaborator
There was a problem hiding this comment.
Can we have more information on this message? e.g., SQLancer image name, tag, etc. Also, for similar messages later in build.py.
| # Run the command and tee output to both console and log file | ||
| eval "$CMD" 2>&1 | tee -a "$LOG_FILE" | ||
| # Run command: log everything, show only stats to console | ||
| eval "$CMD" 2>&1 | tee -a "$LOG_FILE" | grep --line-buffered "Executed" |
Collaborator
There was a problem hiding this comment.
I guess these outputs are inside the docker container? Perhaps we don't need to filter it. We can use -d when running the sqlancer container. Users could use docker logs sqlancer-xxx to see the logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.