Allow SoapFaultMappingExceptionResolver to use strategy to obtain SoapFaultDefinition [SWS-117]

[gregturn]

Barry Kaplan opened SWS-117 and commented

I would like to use something @SoapFault on the exception class to generate the SoapFaultDefinition. But SoapFaultMappingExceptionResolver.getFaultDefinition is private, and hence I pretty much need to reimplement that entire class.

Maybe another level of abstract class with a concrete class subclass that does what SoapFaultMappingExceptionResolver now. Or a strategy interface to which SoapFaultMappingExceptionResolver delegates, with a default strategy that again does what SoapFaultMappingExceptionResolver now.

I would prefer the latter because when I obtain the annotation from the exception I want to be able to use the MessageSource and resolve parameter placeholders from the string contained in the annotation.

---

Affects: 1.0 M3

[gregturn]

Arjen Poutsma commented

I like this idea (@SoapFault), and I think will implement something similar before 1.0. It fits nicely with the @Endpoint and other annotations.

[gregturn]

Arjen Poutsma commented

Done, and documented.

[gregturn]

Arjen Poutsma commented

In the end, I decided not to go for a strategy interface, because that increases the amount of configuration. I've made an AbstractSoapFaultDefinitionExceptionResolver, with a getFaultDefinition() template method, and also a customizeFault() method.

[gregturn]

Arjen Poutsma commented

Closing RC1 issues.

[gregturn]

Barry Kaplan commented

Very nice.