Skip to content

Propagate saml authentication exception gh-7375 #7432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 24, 2019
Merged

Propagate saml authentication exception gh-7375 #7432

merged 2 commits into from
Sep 24, 2019

Conversation

fhanik
Copy link
Contributor

@fhanik fhanik commented Sep 13, 2019

SAML Assertion validation should propagate errors: #7375

fhanik
fhanik commented Sep 13, 2019
View reviewed changes
jzheaux
jzheaux requested changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fhanik, for the PR. I've left some feedback inline.

...framework/security/saml2/provider/service/authentication/OpenSamlAuthenticationProvider.java
final SAML20AssertionValidator validator = getAssertionValidator(token);
Map<String, Object> validationParams = new HashMap<>();
validationParams.put(SAML2AssertionValidationParameters.SIGNATURE_REQUIRED, false);
validationParams.put(
SAML2AssertionValidationParameters.CLOCK_SKEW,
this.responseTimeValidationSkew
this.responseTimeValidationSkew.toMillis()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be in a separate commit so that it can either be tied to a new issue or to the original SAML support issue.

The main reason for this is that it's not about error propagation, which is the theme of this PR.

@fhanik fhanik force-pushed the feature/propagate_saml_authentication_exception branch 2 times, most recently from e0030fb to f3f1e95 Compare September 17, 2019 17:28
jzheaux
jzheaux requested changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, @fhanik! I've left a bit more feedback inline.

@fhanik fhanik force-pushed the feature/propagate_saml_authentication_exception branch from edf140a to d472e99 Compare September 24, 2019 21:43
@fhanik fhanik merged commit e9619fb into spring-projects:master Sep 24, 2019
fhanik added a commit to fhanik/spring-security that referenced this pull request Sep 24, 2019
@fhanik
Revert "Merge pull request spring-projects#7432 from fhanik/feature/p…
adde18b 
…ropagate_saml_authentication_exception"

This reverts commit e9619fb, reversing
changes made to 45a1490.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhanik @jzheaux