INT-4318: Register Jackson modules if available #2209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: https://jira.spring.io/browse/INT-4318 Do not `ObjectMApper.findAndRegisterModules()` unconditionally. If there is no the target module library in classpath, we end up with the `NoClassDefFoundError` * Copy-paste the well-known modules registration logic from the `org.springframework.http.converter.json.Jackson2ObjectMapperBuilder` since we can't add `spring-web` dependency to the `SI-core`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/INT-4318
Do not
ObjectMApper.findAndRegisterModules()unconditionally.If there is no the target module library in classpath, we end up
with the
NoClassDefFoundErrororg.springframework.http.converter.json.Jackson2ObjectMapperBuildersince we can't add
spring-webdependency to theSI-coreTested on the SI Samples reverting commit: spring-projects/spring-integration-samples@68377fe