-
Notifications
You must be signed in to change notification settings - Fork 38.5k
Improve documentation of matrix variables. #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28780,6 +28780,38 @@ Note that to enable the use of matrix variables, you must set the | |
`removeSemicolonContent` property of `RequestMappingHandlerMapping` to `false`. By | ||
default it is set to `true`. | ||
|
||
[TIP] | ||
==== | ||
|
||
The MVC Java config and the MVC namespace both provide options for enabling the use of | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be useful to add a reference to the section on "Advanced Customizations with MVC Java Config" since the above is not possible to do with the @EnableWebMvc/WebMvcConfigurer combo which is the starting point for using the MVC java config. |
||
matrix variables. | ||
|
||
If you are using Java config, The <<mvc-config-advanced-java, Advanced Customizations | ||
with MVC Java Config>> section describes how the `RequestMappingHandlerMapping` can | ||
be customized. | ||
|
||
In the MVC namespace, the `<mvc:annotation-driven>` element has an | ||
`enableMatrixVariables` attribute that should be set to `true`. By default it is set | ||
to `false`. | ||
|
||
[source,xml,indent=0] | ||
[subs="verbatim,quotes"] | ||
---- | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<beans xmlns="http://www.springframework.org/schema/beans" | ||
xmlns:mvc="http://www.springframework.org/schema/mvc" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation=" | ||
http://www.springframework.org/schema/beans | ||
http://www.springframework.org/schema/beans/spring-beans.xsd | ||
http://www.springframework.org/schema/mvc | ||
http://www.springframework.org/schema/mvc/spring-mvc.xsd"> | ||
|
||
<mvc:annotation-driven enableMatrixVariables="true"/> | ||
|
||
</beans> | ||
---- | ||
==== | ||
|
||
[[mvc-ann-requestmapping-consumes]] | ||
===== Consumable Media Types | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above text should not be deleted IMO. It covers those who use neither the MVC namespace nor the MVC Java config. It makes sense to keep it as information on where the configuration setting lives. Then the tip explains how it relates to MVC namespace and Java config users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is redundant information to me (I didn't delete it, I moved it). Would be this useful when not using Java config? If so, that's what I am missing.