Skip to content

DispatcherHandler no longer orders HandlerMapping beans [SPR-15991] #20541

Closed
@spring-projects-issues

Description

@spring-projects-issues

Andy Wilkinson opened SPR-15991 and commented

This change has introduced a regression which means that HandlerMapping beans are no longer ordered. Currently, this.handlerMappings is being sorted:

ArrayList<HandlerMapping> mappings = new ArrayList<>(mappingBeans.values());
AnnotationAwareOrderComparator.sort(this.handlerMappings);
this.handlerMappings = Collections.unmodifiableList(mappings);

I believe it should be mappings that is sorted:

ArrayList<HandlerMapping> mappings = new ArrayList<>(mappingBeans.values());
AnnotationAwareOrderComparator.sort(mappings);
this.handlerMappings = Collections.unmodifiableList(mappings);

Affects: 5.0 GA

Issue Links:

Referenced from: commits 816a58f, 31619b3, f9b319d

Metadata

Metadata

Assignees

Labels

in: webIssues in web modules (web, webmvc, webflux, websocket)type: bugA general bug

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions