Skip to content

Update auditevents.adoc #45795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update auditevents.adoc #45795

wants to merge 1 commit into from

Conversation

tdinev
Copy link

@tdinev tdinev commented Jun 5, 2025

Adapt date in explanation to snippet content

Adapt date in explanation to snippet content

Signed-off-by: Todor Dinev <[email protected]>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 5, 2025
@wilkinsona
Copy link
Member

Thanks for the proposal but this will be wrong again the next time the documentation is built as the snippet's content is dynamic. Instead, filteredAuditEvents() in AuditEventsEndpointDocumentationTests should be updated to use a hard-coded timestamp as allAuditEvents() already does.

Would you like to rework your PR to make this change to the test instead?

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Jun 5, 2025
@tdinev
Copy link
Author

tdinev commented Jun 5, 2025

Certainly. I apologize; I made the change without even consulting the snippet.

@tdinev tdinev closed this Jun 5, 2025
@wilkinsona wilkinsona removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Jun 5, 2025
tdinev added a commit to tdinev/spring-boot that referenced this pull request Jun 5, 2025
Use fixed timestamp in test to make documentation reproducible

concerns: spring-projects#45795

Signed-off-by: Todor Dinev <[email protected]>
@philwebb philwebb added the status: declined A suggestion or change that we don't feel we should currently apply label Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants