Polish Micrometer tracing changes #30833
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
left a comment
wilkinsona
left a comment
There was a problem hiding this comment.
Thanks very much for the PR, @izeye. I've left a couple of comments for your consideration when you have time.
| assertThat(context).hasBean("customTracer"); | ||
| assertThat(context).hasSingleBean(Tracer.class); | ||
| }); | ||
| this.contextRunner.withUserConfiguration(CustomConfiguration.class).run((context) -> { |
There was a problem hiding this comment.
I think we need OpenTelemetryConfiguration here so that @ConditionalOnBean(OpenTelemetry.class) on OpenTelemetryConfigurations.TracerConfiguration.otelTracer(OpenTelemetry) is satisfied and the test is then checking the @ConditionalOnMissingBean.
There was a problem hiding this comment.
@wilkinsona Oops, I missed it. I reverted this change.
| } | ||
|
|
||
| @Test | ||
| void shouldNotSupplyRestTemplateSenderIfNoBuilderIsAvailable() { |
There was a problem hiding this comment.
Just to double-check my understanding, I assume you have removed this test as it duplicates shouldSupplyBeans()?
There was a problem hiding this comment.
@wilkinsona Yes, it seems to be a duplicate of shouldSupplyBeans().
wilkinsona
added
type: task
3 participants
This PR polishes Micrometer tracing changes a bit.