Skip to content

Refactor Mustache template support in Spring MVC #8941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bclozel opened this issue Apr 19, 2017 · 0 comments
Closed

Refactor Mustache template support in Spring MVC #8941

bclozel opened this issue Apr 19, 2017 · 0 comments
Assignees
@bclozel
Labels
type: enhancement A general enhancement
Milestone
2.0.0.M1

Comments

@bclozel
Copy link
Member

bclozel commented Apr 19, 2017

The current Mustache support for Spring MVC:

  • implements a custom i18n support (not in line with the use of Mustache lambdas)
  • does most of the work in the ViewResolver vs doing this in the View itself, which is the usual for other implementations

We should remove that custom i18n in favor of a Mustache support aligned with the one implemented for Spring WebFlux (see #8648).
@bclozel bclozel added this to the 2.0.0.M1 milestone Apr 19, 2017
@bclozel bclozel self-assigned this Apr 19, 2017
philwebb added a commit that referenced this issue Apr 25, 2017
@philwebb
Refine Mustache support
1ad318d 
Refine Mustache support to provide a cleaner separation between the
reactive and servlet implementations. The views have now moved to the
`spring-boot` project and the auto-configuration has been split into
two distinct `@Imports` to save needing full package declarations.

See gh-8941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.0.0.M1
Development

No branches or pull requests
1 participant
@bclozel