Skip to content

Refine ImportsContextCustomizer so that filters are not required #7953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philwebb opened this issue Jan 11, 2017 · 0 comments
Closed

Refine ImportsContextCustomizer so that filters are not required #7953

philwebb opened this issue Jan 11, 2017 · 0 comments
Assignees
@philwebb
Labels
type: enhancement A general enhancement
Milestone
1.5.0

Comments

@philwebb
Copy link
Member

If there was an alternative to ImportSelector that allowed selectImports to be called early and without any BeanFactoryAware etc. callbacks we could use that as the key and get rid of all the stupid filtering.
@philwebb philwebb added this to the 2.0.0.M1 milestone Jan 11, 2017
@wilkinsona wilkinsona mentioned this issue Jan 11, 2017
Closed
@philwebb philwebb modified the milestones: 2.0.0.M1, 2.0.0 Jan 12, 2017
@philwebb philwebb self-assigned this Jan 12, 2017
@philwebb philwebb modified the milestones: 1.5.0, 2.0.0 Jan 12, 2017
@wilkinsona wilkinsona modified the milestones: 2.0.0.M1, 1.5.0 Jan 26, 2017
@philwebb philwebb modified the milestones: 1.5.0, 2.0.0.M1 Jan 28, 2017
wilkinsona added a commit that referenced this issue Jan 30, 2017
@wilkinsona
Remove empty test
dd40516 
The caching behaviour when using ImportAutoConfiguration is covered
by tests in spring-boot-test-auto-configuration, specifically by
ImportsContextCustomizerFactoryWithAutoConfigurationTests.

See gh-7953
@wilkinsona wilkinsona mentioned this issue May 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
2 participants
@philwebb @wilkinsona