Skip to content

Remove ZipkinAutoConfigurationIntegrationTests as it's no longer relevant #45847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Jun 6, 2025 · 0 comments
Closed
Assignees
Labels
type: task A general task
Milestone

Comments

@wilkinsona
Copy link
Member

Support for RestTemplate- and WebClient-based senders was deprecated in 3.3 and then removed in 3.5. The removal made ZipkinAutoConfigurationIntegrationTests irrelevant as the cycles that it tests for are no longer a concern.

@wilkinsona wilkinsona added this to the 3.5.x milestone Jun 6, 2025
@wilkinsona wilkinsona self-assigned this Jun 6, 2025
@wilkinsona wilkinsona added the type: task A general task label Jun 6, 2025
@wilkinsona wilkinsona modified the milestones: 3.5.x, 3.5.1 Jun 9, 2025
wilkinsona added a commit that referenced this issue Jun 10, 2025
Binding in the child context does not work correctly when an
environment prefix has been configured. The prefix is not applied
to the child context's Environment and, therefore, prefixed
environment variables are ignored during binding.

We can fix the problem by reusing the parent context's
ManagementServerProperties rather than binding them again in the
child context. Doing so will fix the problem reported in gh-45857
that was introduced in 020fd7b and will also avoid an unnecessary
second binding of the properties.

gh-45858 may fix the problem more generally by applying the prefix
to the child context's environment. This would benefit situations
where the properties need to be bound in the child context because
they haven't already been bound in the parent.

Closes gh-45847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant