Skip to content

Include DispatcherServlets only exposed as a ServletRegistrationBean in the mappings endpoint #13186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
filiphr opened this issue May 15, 2018 · 3 comments
Assignees
Labels
status: superseded An issue that has been superseded by another type: bug A general bug
Milestone

Comments

@filiphr
Copy link
Contributor

filiphr commented May 15, 2018

When a DispatcherServlet is registered via:

@Bean
public ServletRegistrationBean<DispatcherServlet> idmServlet(MyProperties properties) {
    return registerServlet(properties.getServlet(), IdmEngineRestConfiguration.class);
}

Then when the mappings endpoint is invoked then the
context.application.mappings.servlet correctly contains that servlet information. However, under context.application.mappings.dispatcherServlets only the dispatcherServlet and not my custom servlet mappings are displayed.

It would be good if ServletRegistrationBean(s) are also considered as part of the MappingsEndpoint

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 15, 2018
@wilkinsona wilkinsona changed the title ServletRegistrationBean<DispatcherServlet> are not part of the Mappings Actuator endpoint Include DispatcherServlets only exposed as a ServletRegistrationBean in the mappings endpoint May 16, 2018
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 16, 2018
@wilkinsona wilkinsona added this to the Backlog milestone May 16, 2018
filiphr added a commit to filiphr/spring-boot that referenced this issue May 17, 2018
…in the mappings endpoint

Iterates all ServletRegistrationBeans and adds their mappings in case their Servlet is a DispatcherServlet.
Makes sure that a servlet registered through ServletRegistrationBean and exposed as a Bean is not
described twice.

Fixes spring-projectsgh-13186
filiphr added a commit to filiphr/spring-boot that referenced this issue May 19, 2018
…in the mappings endpoint

Iterates all ServletRegistrationBeans and adds their mappings in case their Servlet is a DispatcherServlet.
Makes sure that a servlet registered through ServletRegistrationBean and exposed as a Bean is not
described twice.

Fixes spring-projectsgh-13186
@philwebb
Copy link
Member

Closing in favor of PR #13211

@philwebb philwebb added status: duplicate A duplicate of another issue and removed type: enhancement A general enhancement labels May 24, 2018
@philwebb philwebb removed this from the Backlog milestone May 24, 2018
@filiphr
Copy link
Contributor Author

filiphr commented May 27, 2018

@philwebb just out of my curiosity (want to understand how your labels are working). You closed this in favor of the PR (this part I get). You then marked it as duplicate, I assume a duplicate of the PR, but the PR is actually a fix for this issue.

@snicoll
Copy link
Member

snicoll commented May 27, 2018

github doesn’t make a difference between an issue and a PR. We’ll use the PR to track the issue described here so this issue becomes a duplicate of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another type: bug A general bug
Projects
None yet
Development

No branches or pull requests

5 participants