-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Include DispatcherServlets only exposed as a ServletRegistrationBean in the mappings endpoint #13186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
…in the mappings endpoint Iterates all ServletRegistrationBeans and adds their mappings in case their Servlet is a DispatcherServlet. Makes sure that a servlet registered through ServletRegistrationBean and exposed as a Bean is not described twice. Fixes spring-projectsgh-13186
…in the mappings endpoint Iterates all ServletRegistrationBeans and adds their mappings in case their Servlet is a DispatcherServlet. Makes sure that a servlet registered through ServletRegistrationBean and exposed as a Bean is not described twice. Fixes spring-projectsgh-13186
Closing in favor of PR #13211 |
@philwebb just out of my curiosity (want to understand how your labels are working). You closed this in favor of the PR (this part I get). You then marked it as duplicate, I assume a duplicate of the PR, but the PR is actually a fix for this issue. |
github doesn’t make a difference between an issue and a PR. We’ll use the PR to track the issue described here so this issue becomes a duplicate of it. |
When a
DispatcherServlet
is registered via:Then when the
mappings
endpoint is invoked then thecontext.application.mappings.servlet
correctly contains that servlet information. However, undercontext.application.mappings.dispatcherServlets
only thedispatcherServlet
and not my custom servlet mappings are displayed.It would be good if
ServletRegistrationBean
(s) are also considered as part of theMappingsEndpoint
The text was updated successfully, but these errors were encountered: