Remove Object... varargs overloads in FilterExpressionBuilderTests
#3489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we swipe
Listwhere in the generic we don't haveObject, we hitObject...which is wrong, and we make a double list. That is, one element is added in this case, which is fundamentally wrong.There are two ways to fix this. Either remove overloading with
Object...(as I did), or makeFilterExpressionBuilderTestsgeneric and makeList<T>values in the argument of acceptance. However, both changes are breaking.If the second option is better for you to fix the problem I am ready to discuss it as I like both options I have given.
The test I gave will not work without changes in the class itself.
Fix: #3482