-
Notifications
You must be signed in to change notification settings - Fork 49
Getting Started tutorial #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for writing this guide. Looks great for a start!! I've made a few editing comments as suggestions for improvement. Feel free to incorporate as is or adjust them a bit in case I deviated from the original intent too much.
Besides that, I think the structure should mirror that of other guides, with complete
and initial
sub-directories. So what is currently the graphql-server
sub-directory becomes complete
. I'll ask @bclozel for a second opinion on this but it seems like it should match other Getting Started guides, e.g. gs-rest-service.
Also @bclozel we should probably rename the project to gs-graphql-server
, but let's finish with the PR first.
I think show an
I don't actually know. @Buzzardo, any suggestions? |
It's generally a good idea to link to the same repository, because we can control that location. Really, though, any location will do, so long as the image isn't likely to go away. |
I want this guide to sound like we all wrote it together so thanks for the comments! |
Co-authored-by: Rossen Stoyanchev <[email protected]>
Co-authored-by: Rossen Stoyanchev <[email protected]>
Co-authored-by: Rossen Stoyanchev <[email protected]>
Co-authored-by: Rossen Stoyanchev <[email protected]>
Co-authored-by: Rossen Stoyanchev <[email protected]>
Co-authored-by: Rossen Stoyanchev <[email protected]>
Co-authored-by: Rossen Stoyanchev <[email protected]>
Co-authored-by: Rossen Stoyanchev <[email protected]>
Co-authored-by: Rossen Stoyanchev <[email protected]>
Co-authored-by: Rossen Stoyanchev <[email protected]>
Hi @rstoyanchev I've put through all your suggestions. I'm ready for another review.
Feel free to comment on the testing section. Additionally, could I add author credit to the tutorial? As this tutorial is based off the GraphQL Java tutorial, I would like to add @bbakerman and @andimarek as co-authors. |
I've just merged this PR with a few additional changes (including the author credit suggested by @dondonz ). Thanks! |
Thanks @bclozel and @rstoyanchev ! It looks great https://spring.io/guides/gs/graphql-server/ |
Hello @rstoyanchev and @bclozel! Here's my first draft of the Getting Started guide for Spring for GraphQL.
I have a question about the testing section. What sort of test would you like to focus on? Did you want to demonstrate an application test or an end-to-end test including testing HTTP? I thought it would be good to show off at least one of the Spring for GraphQL test helpers, rather than having a plain unit test. Whatever we decide on, I'll add this in.
Also, what's the best way to link to images? Should I link to the GitHub raw link in this repository, or should it be hosted elsewhere? I have a single image to show the GraphiQL playground with the query and response.
cc @andimarek @bbakerman