Split rom.HardMode into separate config flags on World #951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace this with individual config flags on the world class
compiling
reviewed
Jul 23, 2021
sporchia
approved these changes
Jul 24, 2021
Owner
sporchia
left a comment
sporchia
left a comment
There was a problem hiding this comment.
good to ship as is, but question about stuns
| $this->config['rom.BottleFill.Magic'] = 0x00; // nothing | ||
| $this->config['rom.CatchableFairies'] = false; | ||
| $this->config['rom.CatchableBees'] = true; | ||
| $this->config['rom.StunItems'] = 0x00; |
Owner
There was a problem hiding this comment.
Can we discuss just nix'ing the stun stopping? After a while of playing/testing this, it's just not fun or more challenging, but I could be wrong?
Collaborator
Author
There was a problem hiding this comment.
I'm good with this, I think the boomerang/hookshot stun changes are the thing most people find objectionable with item functionality, I think removing it is a good call. I'd still like to keep rom.StunItems as a config key.
| $rom->setBottleFills([$this->config('rom.BottleFill.Health', 0xA0), $this->config('rom.BottleFill.Magic', 0x80)]); | ||
| $rom->setCatchableFairies($this->config('rom.CatchableFairies', true)); | ||
| $rom->setCatchableBees($this->config('rom.CatchableBees', true)); | ||
| $rom->setStunItems($this->config('rom.StunItems', 0x03)); |
Owner
There was a problem hiding this comment.
see earlier stun items question
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us more flexibility to only make specific changes that are provided by the item functionality setting. We get rid of rom.HardMode and instead break it into individual flags that are wrapped up into item.functionality
Additionally, it lets us set the amount the escape checkpoints refill a resource for, based on uncle weapon.
Finally, it switches the hard item shop changes to be based on Item Pool setting, not Item Functionality. This is also a separate flag that we can then set at will.