Skip to content

Conversation

@DoctorBlue
Copy link
Contributor

@DoctorBlue DoctorBlue commented Jun 6, 2021

  • The post-generation Save ROM screen styles updated to match the permalink ROM Info screen
    • Primarily accomplished by copying CSS/HTML from one to the other, and removing duplicate / unnecessary styles
    • Before:
      image
    • After:
      image
    • Compare to the currently-live version of the permalink screen:
      image
    • Only difference stems from post-generation screen having buttons in the header
  • Always show the permalink on the ROM Info screen, even when visiting via permalink
    • Didn't get a strong response in chat as to why we're doing this
    • Wanted the screens to be equivalent as much as possible
  • If you generated a game, then click Change Settings: New button for returning to generated seed
    • Just a simple boolean hack for now
    • Can be expanded to shoving most-recently-generated game into forage, and just always show a link / button somewhere if that has a value
    • Translations provided (though German was from DeepL / automated)
    • Screenshot!
      image

@tcprescott tcprescott requested a review from sporchia June 11, 2021 01:38
@tcprescott tcprescott changed the base branch from v31.0.9 to v31.0.10 July 23, 2021 07:07
@tcprescott tcprescott merged commit 8f373e6 into sporchia:v31.0.10 Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants