Completionist goal #1048
Merged
Completionist goal #1048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update readme New ROM update Refactored to account for free crystals (not supported yet in php) Free dungeon items can be placed in their own dungeon Added Zelda Mirror fix, now mirrors to sanc in escape in glitched modes Update ER and python version Change Beatable to Beatable Only
cassidoxa
force-pushed
the
hundo_features
branch
from
10dd800 to
00c4d65
Compare
sporchia
reviewed
Aug 10, 2023
Owner
sporchia
left a comment
sporchia
left a comment
There was a problem hiding this comment.
looked this over, some comments, will look to figure out a beta site hopefully this week/weekend
Comment on lines
+177
to
+182
| [ | ||
| 'header' => __('randomizer.goal.options.completionist'), | ||
| 'content' => [ | ||
| 'This setting requires collection of all items and full completion of all dungeons. This includes the 3 Light World pendant dungeons, the 7 Dark World crystal dungeons, Agahnim’s Tower and Ganon’s Tower.', | ||
| ], | ||
| ], |
Owner
There was a problem hiding this comment.
we will also want to get translations of this.
More explicit sign hints for completionist Co-authored-by: S <[email protected]>
Suggested fixes
cassidoxa
force-pushed
the
hundo_features
branch
from
1cea9f3 to
0e2110c
Compare
sporchia
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a completionist goal which requires 100% item collection and All Dungeons for Ganon to be vulnerable. This also adds a
rom.hudItemCounteroption that will place a (current item collection count) / (total item collection count) counter on the HUD similar to the triforce hunt counter.This depends on ROM changes included in this pull request. Update the z3randomizer dependency in composer.json accordingly and run
composer updateor delete the composer.lock file before runningcomposer installto test.The documentation has been updated to recommend using the latest Ubuntu long term release, 22, because the old LTS doesn't have PHP 8 packages. As such, the python version called in EntranceRandomizer.php has also been bumped to 3.10 because that's what Ubuntu 22 offers by default.
Breaking changes:
-HUD heart color now written to $B0F020 (0x187020). See HUDHeartColors in tables.asm for documentation.
-Dungeon prizes must have their item receipt ID written to the table at $81C6FC (0xC6FC PC) instead of the vanilla index values.
-Dungeon prize icons for the overworld map must be written to $8ABE76 (0x53E75 PC.) See WorldMapIcon_tile in tables.asm
-Gfx pointers removed from tables.asm.
Misc changes:
-FastROM conversion (kan)
-Item decompression and gfx/properties tables (see itemdatatables.asm, yet to be fully documented) (kan, cassidy)
-Press select to toggle fast credits (kan)
-Hiragana characters restored on file name screen, name screen re-arranged slightly (cassidy)
-Zelda mirror fix that sets the mirror location to Sanctuary in escape in glitched modes after save and quit
-Added rom.vanillaKeys, rom.vanillaBigKeys, etc config flags that converts free dungeon items into their vanilla equivalent for glitched/vanilla speedrun players who want vanilla behavior (eg, cave state items.)
-Heart piece icon color in menu, file select, and credits now matches HUD heart color.
-Substantial hud refactor by kan for speed.