refactor(parser) abstract parser #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parser isn't suitable for this case, parse is a process, not a instance. Parse function will match a local file from a url, containing any other attribute like wrap, pkg and so on. The match will pass to many rules, break when matched, rule can be customize also Closes #11
Member
Author
Don't Merge |
Member
Author
Member
Author
|
改好了 |
popomore
force-pushed
the
refactor-parser
branch
from
7934b35 to
0add271
Compare
lib/util.js
Outdated
Member
|
standalone 的逻辑还有点问题：
|
1. url should be string not object 2. get spm property from pkg.origin.spm 3. standalone should ignore that is not entry
Member
Author
|
已更新 |
Member
There was a problem hiding this comment.
这里的 id 被强制转成小写了? 比如 require('vendor/backbone.localStorage.js')，输出的是 define('vendor/backbone.localstorage.js', ...，导致匹配不上。
Member
Author
There was a problem hiding this comment.
是不是这里有问题 https://github.com/spmjs/serve-spm/blob/0.6.0/lib/express.js#L33
那我先把 lowerCase 去掉
Member
Author
|
已改 |
sorrycc
added a commit
that referenced
this pull request
Nov 14, 2014
refactor(parser) abstract parser
Closed
Member
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parser isn't suitable for this case, parse is a process, not a instance.
Parse function will match a local file from a url, containing any other attribute like wrap, pkg and so on.
The match will pass to many rules, break when matched, rule can be customize also
Closes #11