Skip to content

TR-3506 MITRE MAP Update #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

TR-3506 MITRE MAP Update #413

wants to merge 5 commits into from

Conversation

josehelps
Copy link
Contributor

@josehelps josehelps commented Jun 5, 2025

Updated to support latest navigator 5.1.0 also leveraging all the new features .. looks much nicer

xxx in ~/splunk/contentctl/security_content on develop ● λ poetry run contentctl report --enrichments
Successfully parsed [1730] Atomic Red Team Tests!
Performing MITRE Enrichment using the repository at external_repos/cti...Done!
   DEPLOYMENTS Progress: [100%]...Done!
       LOOKUPS Progress: [100%]...Done!
        MACROS Progress: [100%]...Done!
       STORIES Progress: [100%]...Done!
     BASELINES Progress: [100%]...Done!
INVESTIGATIONS Progress: [  0%]...Done!
  DATA_SOURCES Progress: [100%]...Done!
     PLAYBOOKS Progress: [100%]...Done!
    DETECTIONS Progress: [100%]...Done!
    DASHBOARDS Progress: [100%]...Done!
Creating GitHub Badges...
Generating coverage.json...

✅ MITRE ATT&CK Navigator layer file written to: reporting/coverage.json
📊 Coverage Summary:
   Total Detections: 1772
   Covered Techniques: 314
   Tactics with Coverage: 314

🗺️  To view the layer:
   1. Go to https://mitre-attack.github.io/attack-navigator/
   2. Click 'Open Existing Layer'
   3. Select the file: reporting/coverage.json
Reporting successfully written to 'reporting'

Uploading image.png…

@josehelps josehelps requested a review from pyth0n1c June 5, 2025 23:29
import pathlib
from typing import List, Union
from datetime import datetime
from typing import Any, Dict, List, Set, TypedDict, Union
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Python 3.9, it is not recommended to import simple(r) types from typing like list, dict, or set. This should just be used directly. For example instead of
x:List[str]
instead use
x:list[str]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants