This repository was archived by the owner on Dec 20, 2025. It is now read-only.
fix(ecs): evaluate targetgroup healthcheck in instance healthcheck (backport #6307) #6371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6307) * fix(ecs): include healthcheck status from targetgroups in instance healthcheck * test(ecs): add tests for default behavior and targetgroup healthchecks * fix(ecs): check null for loadBalancer attribute * refactor(ecs): improve testing and use targetHealth to determine status only if containerHealthcheck is UNKNOWN * fix(ecs): evaluate TargetHealth check if container deployed does have target groups associated --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 7ce44a3)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployments using ECS are marked successful by Spinnaker but the ECS service is unhealthy when target group mappings are defined in the configuration.
Here is pipeline execution with the successful deployment in Spinnaker:
But In the server group events we can see unhealthy issues.
Here is the issue in ECS AWS console.
As part of my changes I search for targetGrouphealths and then use them to set unhealthy statuses to the instance.
This is an automatic backport of pull request #6307 done by [Mergify](https://mergify.com).