fix(clouddriver-google): Fix logic when Instance Types are available only in selected Zones/Regions #6351
Conversation
christosarvanitis
requested review from
plumpy and
skandragon
as code owners
...a/com/netflix/spinnaker/clouddriver/google/deploy/handlers/BasicGoogleDeployHandlerTest.java
Outdated
Show resolved
Hide resolved
edgarulg
left a comment
edgarulg
left a comment
There was a problem hiding this comment.
Thanks for working on this fix. Basically the same behavior is kept but it is returning the appropriate error message based on the zone's availability for the machine. Overall looks good to me.
We need to backport this change because it will help GCE Spinnaker Users to know why their deployment failed but older versions still has the groovy implementation. We can make a manual backport if everyone agree.
.../java/com/netflix/spinnaker/clouddriver/google/deploy/handlers/BasicGoogleDeployHandler.java
Outdated
Show resolved
Hide resolved
|
I'd welcome a backport fix on this :) |
christosarvanitis
force-pushed
the
fixGCPZonalInstanceTypes
branch
3 times, most recently
from
66a979a to
ee537e7
Compare
…only in selected Zones/Regions
christosarvanitis
force-pushed
the
fixGCPZonalInstanceTypes
branch
from
ee537e7 to
7295231
Compare
Looks like we need a 1.37.1 as soon as we sort out some retrofit issues. I'm OK with this going there too. We're already behind schedule on releasing 1.36.next, but I suppose this could go there too. How far back are you thinking? |
|
PROBABLY just 1.36 at this point... we'll look see if it needs to go back farther as it'd be useful on that point, given that the errors are confusing, but... no farther back than 1.35 given that 1.37 is out |
|
Since this part of code was refactored heavily for 1.37.x i created this manual backport for groovy to go on 1.36.x #6352 |
|
OK, gonna start with a backport to release-1.37.x |
|
@Mergifyio backport release-1.37.x |
✅ Backports have been createdDetails
|
…only in selected Zones/Regions (#6351) (#6353) (cherry picked from commit 6a65adf) Co-authored-by: Christos Arvanitis <[email protected]>
4 participants
In GCP there are some instance types (like c4-highcpu-X) that are available only in specific Zones per Region (or all of the zones in some other regions).
When the user selects a Regional deployment (Distribute instances across multiple zones) and also selects an instance type that is available only in specific zones in that region:
[Before the fix]: Clouddriver was failing with an error message Instance type not found
[After the fix]: If the instance type selected is available in all the region then it succeeds. If the instance type is not available in all the zones within the region it fails with the appropriate message
When the user selects a Regional deployment (Distribute instances across multiple zones) and Selects the Zones explicitly + also selects an instance type that is available only in specific zones in that region:
[Before the fix]: Clouddriver was failing with an error message Instance type not found
[After the fix]: If the user selects only the Zones that the instance type is available then it succeeds. If the user selects any Zone that the instance type is not available then it fails with the appropriate message.