Skip to content

Use the misc.highlighting_failure warning sub-type for PygmentsBridge.get_lexer() #13335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 15, 2025
Merged

Use the misc.highlighting_failure warning sub-type for PygmentsBridge.get_lexer() #13335

merged 3 commits into from
Feb 15, 2025

Conversation

b-kamphorst
Copy link
Contributor

Purpose

add warning type to PygmentsBridge.get_lexer

References

Closes #13334

@b-kamphorst
Copy link
Contributor Author

Hi! This is my first PR to this project. I tried to follow instructions in updating AUTHORS.rst and CHANGES.rst. I hope the PR is acceptable and I'm happy to take any feedback.

Note: I re-used the existing misc.highlighting_failure warning type as it seems appropriate and was already raised in this class.

@AA-Turner AA-Turner changed the title feat: add type misc.highlighting_failure to PygmentsBridge.get_lexer Use the misc.highlighting_failure warning sub-type for PygmentsBridge.get_lexer() Feb 13, 2025
@AA-Turner AA-Turner added this to the 8.2.0 milestone Feb 13, 2025
@AA-Turner
Copy link
Member

I tried to follow instructions in updating AUTHORS.rst and CHANGES.rst.

I don't think you've pushed this commit.

@b-kamphorst
Copy link
Contributor Author

Classic. Thanks for noting, fixed now.

@AA-Turner AA-Turner merged commit 3b2667e into sphinx-doc:master Feb 15, 2025
23 checks passed
@AA-Turner
Copy link
Member

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a warning subtype for Pygments unknown lexers
2 participants