eliminate use of pkg_resources #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don’t need it for the namespace anymore.
Member
|
This looks OK, although I'm surprised removing the import didn't break anything. Was it just not being used at all? I don't see a dependency on setuptools that we could remove at the same time. This package could use some serious modernization work for all of its packaging. :-) I'll leave it for you to merge when you're ready to tag a release. If you don't have permission to do that, I can try to get it done on a weekend, let me know here. |
Contributor
Author
|
I do not have permission to merge, so please go ahead and do so when you have time. I'm listed as a maintainer on pypi.org. So presumably I could upload from my repo, but it makes more sense to keep yours the master. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been a while since an update, but I still use this in runestone. I was getting deprecation warnings. This seems to still be functional and eliminates the warnings.
I think I have permission to push this to pypi but lets make sure we are in sync on this. Haven't changed version info yet...
I don't think we need any of the pkg_resources stuff for a namespace package anymore.