functions in fish shell completion auto-generated file should not contain "-" character

[umbynos]

As asked by @marckhouzam here, I'm opening this issue.
I'm working on this PR and I noticed a problem with the auto-generated cobra completion file for fish shell: If the root command to complete contains a dash character in the name "-" (e.g. arduino-cli) the autocompletion will not work because of function naming (a function called __arduino-cli_comp_do_file_comp is created). For reference: fish-shell/fish-shell#1206

To fix this I simply replaced "-" with "_" here. But maybe it's better to fix this behaviour in cobra? Something like: if the command name contains a dash character automatically is replaced with an underscore.

[marckhouzam]

Thanks @umbynos.
I noticed that Cobra's bash completion was replacing : for commands.

cobra/bash_completions.go

Line 350 in 94a87a7

name = strings.Replace(name, ":", "__", -1)

It does not affect Fish, but if the program has a : in the name (not a good idea, but supported), it would cause problems.

I will post a PR that replaces both - and : for fish completion.

[marckhouzam]

Fix in #1122