Add cast methods ToUintSlice #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sagikazarmark
approved these changes
Apr 12, 2025
sagikazarmark
requested changes
Apr 12, 2025
There was a problem hiding this comment.
@nmvalera could you please reabase your PR? I added a set of generic functions for slices, could you please use those instead?
Thanks!
|
Overlaps with #179 |
nmvalera
changed the title
|
Hey @sagikazarmark, I have rebased to use the slice utilities. I also noticed that ToFloat64Slice has been implemented in the meantime, so I removed this part from my PR (I just left some extra test cases that were on my PR, as it does not hurt) |
sagikazarmark
approved these changes
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.