-
Notifications
You must be signed in to change notification settings - Fork 10
Lara dsl deprecation #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lm-sousa
wants to merge
112
commits into
staging
Choose a base branch
from
lara-dsl-deprecation
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lara dsl deprecation #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…improved clarity and maintainability
Remove auto-genmerated files from git Add them to .gitignore
…e code clarity and maintainability.
…Weaver build script for consistency and clarity.
…r improved development environment
joaobispo
reviewed
Jul 9, 2025
Comment on lines
+6
to
+10
public class ClavaOptionsManagerLauncher extends WeaverOptionsManagerLauncher { | ||
public static void main(String[] args) { | ||
launchGui(new CxxWeaver()); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
public class ClavaOptionsManagerLauncher extends WeaverOptionsManagerLauncher { | |
public static void main(String[] args) { | |
launchGui(new CxxWeaver()); | |
} | |
} | |
public class ClavaOptionsManagerLauncher { | |
public static void main(String[] args) { | |
WeaverOptionsManagerLauncher.launchGui(new CxxWeaver()); | |
} | |
} |
…for consistency and clarity
…functionality. - This includes the deletion of the ClavaHls project, as well as the associated APIs. -Additionally, update build configurations to reflect the removal of HLS dependencies and resources.
…tDumper and ClangResources
…er source handling
…retrieval and update build.gradle to register the generateWeaver task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.