Skip to content

Conversation

@mcopik
Copy link
Collaborator

@mcopik mcopik commented Nov 6, 2024

This PR replaces #192 by @prajinkhadka - we added a few simple improvements and extended support to Python 3.10 and 3.11.

The combined PRs build Python and Node.js benchmarks with ARM dependencies, create & update Lambda functions with new architecture, extend function name with architecture, extend code build & cache location with architecture suffix, and run regression tests for new architecture.

Summary by CodeRabbit

  • New Features

    • Added support for multiple architectures (x64 and arm64) across various components.
    • Enhanced AWS, GCP, and Azure functions to handle architecture-specific deployments.
    • Introduced new dependencies for image processing and graph manipulation.
  • Bug Fixes

    • Improved error handling and logging for API creation in AWS configurations.
  • Documentation

    • Updated benchmark documentation to include architecture compatibility.
  • Chores

    • Updated dependency versions for improved performance and functionality.

prajinkhadka and others added 30 commits November 5, 2024 23:46
@coderabbitai
Copy link

coderabbitai bot commented Nov 6, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve updates to various configuration files and scripts across multiple benchmarks and projects. Key modifications include upgrading dependency versions, adding new dependencies for image processing and graph manipulation, and enhancing scripts to support architecture-specific installations. Additionally, configuration files have been updated to specify supported architectures for cloud platforms, and several classes have been modified to handle architecture-related logic in function creation and deployment processes.

Changes

File Path Change Summary
benchmarks/200.multimedia/210.thumbnailer/nodejs/package.json Updated "sharp" dependency version from "^0.28" to "^0.32".
benchmarks/200.multimedia/210.thumbnailer/python/requirements.txt.arm.3.8 Added Pillow==10.0.0 dependency.
benchmarks/200.multimedia/210.thumbnailer/python/requirements.txt.arm.3.9 Added Pillow==10.0.0 dependency.
benchmarks/500.scientific/501.graph-pagerank/python/requirements.txt.arm.3.8 Added python-igraph==0.11.4 dependency.
benchmarks/500.scientific/501.graph-pagerank/python/requirements.txt.arm.3.9 Added python-igraph==0.11.4 dependency.
benchmarks/500.scientific/502.graph-mst/python/requirements.txt.arm.3.8 Added python-igraph==0.11.4 dependency.
benchmarks/500.scientific/502.graph-mst/python/requirements.txt.arm.3.9 Added python-igraph==0.11.4 dependency.
benchmarks/500.scientific/503.graph-bfs/python/requirements.txt.arm.3.8 Added python-igraph==0.11.4 dependency.
benchmarks/500.scientific/503.graph-bfs/python/requirements.txt.arm.3.9 Added python-igraph==0.11.4 dependency.
benchmarks/500.scientific/504.dna-visualisation/python/requirements.txt.arm.3.8 Added squiggle==0.3.1 dependency.
benchmarks/500.scientific/504.dna-visualisation/python/requirements.txt.arm.3.9 Added squiggle==0.3.1 dependency.
benchmarks/200.multimedia/220.video-processing/init.sh Modified to support downloading FFmpeg based on architecture, added TARGET_ARCHITECTURE variable.
config/example.json Updated experiments section with "architecture": "arm64" and changed runtime from Python to Node.js with version updates.
config/systems.json Added "architecture" key to various sections with supported architectures.
dockerfiles/nodejs_installer.sh Enhanced npm installation logic for architecture-specific installations.
dockerfiles/python_installer.sh Updated logic for installing Python packages based on architecture.
docs/benchmarks.md Added "Architecture" column to benchmarks table, indicating supported architectures.
sebs.py Introduced --architecture command-line option for specifying target architecture.
sebs/aws/aws.py Enhanced AWS class to handle function architectures in function creation and updates.
sebs/aws/config.py Added retry logic for API creation in http_api method.
sebs/benchmark.py Updated Benchmark class to include architecture handling in various methods.
sebs/cache.py Modified caching methods to incorporate architecture as a parameter.
sebs/config.py Added supported_architecture method to retrieve architecture configurations.
sebs/experiments/config.py Introduced _architecture attribute and updated serialization logic.
sebs/faas/function.py Updated Architecture enum and FunctionConfig class to handle architecture in configurations.
sebs/gcp/gcp.py Enhanced GCP class to include architecture in function naming during creation and updates.
sebs/regression.py Updated regression tests to support multiple architectures and modified test generation logic.
sebs/sebs.py Modified get_deployment method to align with new configuration structure and added architecture validation.

Poem

In the meadow where the code does play,
New dependencies hop, brightening the day.
With architectures dancing, side by side,
Our scripts are now ready for a joyful ride!
So let's leap and bound, with no delay,
For in this code garden, we frolic and sway! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mcopik mcopik merged commit 4f7c5dd into master Nov 6, 2024
1 check failed
@mcopik mcopik deleted the feature/aws-arm branch November 7, 2024 01:42
@coderabbitai coderabbitai bot mentioned this pull request Oct 27, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants