Skip to content

Fix exponential complexity in MapFusionVertical #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
affifboudaoud wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix exponential complexity in MapFusionVertical #2233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions dace/transformation/dataflow/map_fusion_vertical.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1541,11 +1541,15 @@ def _is_data_accessed_downstream(
def next_nodes(node: nodes.Node) -> Iterable[nodes.Node]:
return (edge.dst for edge in graph.out_edges(node))

# Dataflow graph is acyclic, so we do not need to keep a list of
# what we have visited.
# Track visited nodes to avoid exponential blowup from visiting
# the same node multiple times via different paths in the DAG.
to_visit: List[nodes.Node] = list(next_nodes(begin))
visited: Set[nodes.Node] = set()
while len(to_visit) > 0:
node = to_visit.pop()
if node in visited:
continue
visited.add(node)
if isinstance(node, nodes.AccessNode) and node.data == data:
return True
to_visit.extend(next_nodes(node))
Expand Down