Add connector dealiasing #2161
Draft
Add connector dealiasing #2161
+156
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbennun
reviewed
Sep 25, 2025
tbennun
reviewed
Sep 25, 2025
dace/sdfg/dealias.py
Outdated
| Args: | ||
| sdfg (dace.SDFG): Modified in-place. | ||
| """ | ||
| recurse_in: Set[dace.nodes.NestedSDFG] = set() |
Collaborator
There was a problem hiding this comment.
should the function run recursively?
Collaborator
Author
There was a problem hiding this comment.
I think yes, if nested SDFG has more nested SDFGs the function should just continue doing?
dace/sdfg/dealias.py
Outdated
| return candidate_name | ||
|
|
||
|
|
||
| def dealias(sdfg: dace.SDFG): |
Collaborator
There was a problem hiding this comment.
maybe find a better name such as make_unique_nested_data or something
Collaborator
Author
There was a problem hiding this comment.
I think of the name def find_readable_connector_names_for_nested_sdfgs(sdfg: dace.SDFG): what do you think?
dace/sdfg/dealias.py
Outdated
| return candidate_name | ||
| else: | ||
| i = 1 | ||
| candidate_name = f"{edge.data.data}_{SLICE_SUFFIX}_{i}" |
Collaborator
There was a problem hiding this comment.
actually, you can also use data.find_new_name(f'{edge.data.data}_{SLICE_SUFFIX}') to get A_slice followed by A_slice_#
Collaborator
Author
There was a problem hiding this comment.
I will use find_new_name and remove FULLVIEW_SUFFIX
tbennun
reviewed
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice NSDFG connector names:
This:
Becomes:
