Fix module references #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you update the PR so that it doesn't remove all the tabs from empty lines? This will both keep the code styling correct and will ensure the "Files changed" tab isn't too confusing. |
WebCloud
force-pushed
the
fix-module-usage
branch
from
a8495d8 to
4618409
Compare
Author
|
I am sorry, I forgot my default setup on Atom and have not checked the full diff. |
Author
|
The commit is now fixed with only the actual fixes. |
Fix the reference to CodeMirror by instead of trying to use a global, require the module. Also fix the usage of Typo, using the same principles. This fixes sparksuite#14 for good.
WebCloud
force-pushed
the
fix-module-usage
branch
from
4618409 to
3b2c340
Compare
|
@WesCossick Any update on this? It would be really nice to have this fixed |
Member
|
Last step, @WebCloud can you compare this same PR again the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the reference to CodeMirror by instead of trying to use a global,
require the module. Also fix the usage of Typo, using the same
principles. This fixes #14 for good.