Give _int_pin and _reset_pin sane default values #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assign sane default values to _int_pin and _reset_pin. Otherwise they get assigned zero and all the "if (_int_pin == -1)" checks fail and bad things happen.
lewispg228
force-pushed
the
pin-defaults
branch
from
2a54b78 to
24a42d5
Compare
|
Good catch. All of our library examples were recently updated to use (and define) the INT and RST pins, so we hadn't come across this issue yet. Thanks for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assign sane default values to _int_pin and _reset_pin. Otherwise they get assigned zero and all the "if (_int_pin == -1)" checks fail and bad things happen.