Skip to content

Conversation

@pllim
Copy link
Contributor

@pllim pllim commented May 2, 2025

Description

This pull request is to fix #411

@github-actions
Copy link

github-actions bot commented May 2, 2025

Thank you for your contribution! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the STScI coding guidelines?
  • Are tests added/updated as required? If so, do they follow the STScI testing guidelines?
  • Are docs added/updated as required?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed?

@github-actions
Copy link

github-actions bot commented May 2, 2025

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim added the Build wheels Test wheels on PR label May 2, 2025
@codecov
Copy link

codecov bot commented May 2, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.14%. Comparing base (f0b162e) to head (5500f9e).
⚠️ Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
synphot/compat_specutils.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #413      +/-   ##
==========================================
- Coverage   97.18%   97.14%   -0.04%     
==========================================
  Files          17       18       +1     
  Lines        2026     2035       +9     
==========================================
+ Hits         1969     1977       +8     
- Misses         57       58       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pllim pllim marked this pull request as ready for review May 2, 2025 21:38
@pllim pllim merged commit 4044b92 into spacetelescope:master May 2, 2025
22 of 24 checks passed
@pllim pllim deleted the specutils-2.0 branch May 2, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[email protected]: 12 unit tests failed (DeprectionWarning) with specutils 2.0

1 participant