Skip to content

feat: Remove ancient attributes #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gregkare wants to merge 3 commits into
base: main
Choose a base branch
from
+1 −8
Open

feat: Remove ancient attributes #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a256e63
Remove ancient attribute
gregkare Sep 9, 2025
b895c89
Fix tests
gregkare Sep 9, 2025
3f39c7d
Try to fix integration test
gregkare Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions recipes/_attributes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@
node.default_unless['postfix']['sasl_password_file'] = "#{node['postfix']['conf_dir']}/sasl_passwd"
node.default_unless['postfix']['main']['smtp_sasl_password_maps'] = "#{node['postfix']['db_type']}:#{node['postfix']['sasl_password_file']}"
node.default_unless['postfix']['main']['smtp_sasl_security_options'] = 'noanonymous'
node.default_unless['postfix']['sasl']['smtp_sasl_user_name'] = ''
node.default_unless['postfix']['sasl']['smtp_sasl_passwd'] = ''
node.default_unless['postfix']['main']['relayhost'] = ''
end

Expand Down
2 changes: 0 additions & 2 deletions test/integration/sasl_auth_multiple/controls/sasl_auth_multiple.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@

relayhost1 kitchenuser:not-a-real-thing
relayhost2 anotherkitchenuser:yet-not-a-real-thing
smtp_sasl_passwd :
smtp_sasl_user_name :
EOF
end
end
Expand Down
3 changes: 1 addition & 2 deletions test/integration/sasl_auth_none/controls/sasl_auth_none.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
# Auto-generated by Chef.
# Local modifications will be overwritten.

smtp_sasl_passwd :
smtp_sasl_user_name :

EOF
end
end
Expand Down
2 changes: 0 additions & 2 deletions test/integration/sasl_auth_one/controls/sasl_auth_one.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
# Local modifications will be overwritten.

relayhost kitchenuser:not-a-real-thing
smtp_sasl_passwd :
smtp_sasl_user_name :
EOF
end
end
Expand Down
Loading